Merged
Conversation
RAY-316
requested review from
00Kai0,
jsntcy,
msyyc and
zhangyan133
as code owners
|
Hi, @RAY-316 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Security/locations/{ascLocation}/ExternalSecuritySolutions' Location: Microsoft.Security/stable/2020-01-01/externalSecuritySolutions.json#L76 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/locations/{ascLocation}/ExternalSecuritySolutions/{externalSecuritySolutionsName}' Location: Microsoft.Security/stable/2020-01-01/externalSecuritySolutions.json#L118 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2017-08-01-preview/securityContacts.json#L185 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2017-08-01-preview/workspaceSettings.json#L216 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/automations.json#L239 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/stable/2020-01-01/assessmentMetadata.json#L248 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2017-08-01-preview/compliances.json#L163 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L371 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L376 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/security/resource-manager/readme.md tag: specification/security/resource-manager/readme.md#tag-package-composite-v3 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"security/resource-manager/readme.md",
"tag":"package-composite-v3",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"security/resource-manager/readme.md",
"tag":"package-composite-v3",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Duplicate Schema named ExternalSecuritySolutionKind -- type: undefined => "string", properties: "kind":"x-ms-enum":"name":"ExternalSecuritySolutionKind", "modelAsString":true, "values":["value":"CEF", "value":"ATA", "value":"AAD"], "$ref":"#/components/schemas/ExternalSecuritySolutionKind", "description":"The kind of the external solution" =>, enum: undefined => ["CEF", "ATA", "AAD"], x-ms-enum: undefined => "name":"ExternalSecuritySolutionKind", "modelAsString":true, "values":["value":"CEF", "value":"ATA", "value":"AAD"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Duplicate Schema named AadConnectivityState -- type: undefined => "string", properties: "connectivityState":"x-ms-enum":"name":"AadConnectivityState", "modelAsString":true, "values":["value":"Discovered", "value":"NotLicensed", "value":"Connected"], "$ref":"#/components/schemas/AadConnectivityState" =>, title: undefined => "The connectivity state of the external AAD solution ", enum: undefined => ["Discovered", "NotLicensed", "Connected"], x-ms-enum: undefined => "name":"AadConnectivityState", "modelAsString":true, "values":["value":"Discovered", "value":"NotLicensed", "value":"Connected"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"security/resource-manager/readme.md", "tag":"package-2020-01-only", "details":"Duplicate Schema named ExternalSecuritySolutionKind -- type: undefined => "string", properties: "kind":"x-ms-enum":"name":"ExternalSecuritySolutionKind", "modelAsString":true, "values":["value":"CEF", "value":"ATA", "value":"AAD"], "$ref":"#/components/schemas/ExternalSecuritySolutionKind", "description":"The kind of the external solution" =>, enum: undefined => ["CEF", "ATA", "AAD"], x-ms-enum: undefined => "name":"ExternalSecuritySolutionKind", "modelAsString":true, "values":["value":"CEF", "value":"ATA", "value":"AAD"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"security/resource-manager/readme.md", "tag":"package-2020-01-only", "details":"Duplicate Schema named AadConnectivityState -- type: undefined => "string", properties: "connectivityState":"x-ms-enum":"name":"AadConnectivityState", "modelAsString":true, "values":["value":"Discovered", "value":"NotLicensed", "value":"Connected"], "$ref":"#/components/schemas/AadConnectivityState" =>, title: undefined => "The connectivity state of the external AAD solution ", enum: undefined => ["Discovered", "NotLicensed", "Connected"], x-ms-enum: undefined => "name":"AadConnectivityState", "modelAsString":true, "values":["value":"Discovered", "value":"NotLicensed", "value":"Connected"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"security/resource-manager/readme.md", "tag":"package-2020-01-only", "details":"Error: Plugin prechecker reported failure." |
| 💬 AutorestCore/Exception | "readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
| 💬 AutorestCore/Exception | "readme":"security/resource-manager/readme.md", "tag":"package-2020-01-only", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"security/resource-manager/readme.md", "tag":"package-2020-01-only", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
msyyc
approved these changes
Jun 7, 2021
msyyc
reviewed
Jun 9, 2021
| "enum": [ | ||
| false, | ||
| true | ||
| ], |
Member
There was a problem hiding this comment.
type 'boolean' only has two kinds of valuses : 'true' and 'false'. So there is no need to define it redundantly.
Member
There was a problem hiding this comment.
@ArcturusZhang @weidongxu-microsoft @dw511214992 @allenjzhang
We delete redundant enum definition for 'boolean', please check whether it influence your language.
msyyc
requested review from
ArcturusZhang,
allenjzhang,
dw511214992 and
weidongxu-microsoft
Member
|
OK for Java. We haven't released yet. |
This was referenced Jun 15, 2021
Closed
Closed
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
* sql t2 readme config * readme config * Update readme.python.md * conflient resolve * security t2 config * modelerfour config * Delete duplicate JSON files * del test * Update readme.md * directive x-ms-enum * delete redundant definition Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/1644
#11540